mike-goodwin / owasp-threat-dragon

An open source, online threat modelling tool from OWASP

http://mike-goodwin.github.io/owasp-threat-dragon/

Apache License 2.0

483 stars 130 forks source link

Update Travis and Remove PhantomJS #127

Closed jgadsden closed 4 years ago

guardrails[bot] commented 4 years ago

:warning: We detected security issues in this pull request:

Vulnerable Libraries (2)

- [constantinople@3.0.2](https://github.com/mike-goodwin/owasp-threat-dragon/blob/2acf1fff48b5705421991d7b92df09f9ad79fa70/package.json#Lnull) upgrade to `>=3.1.1` - [minimatch@2.0.10](https://github.com/mike-goodwin/owasp-threat-dragon/blob/2acf1fff48b5705421991d7b92df09f9ad79fa70/package.json#Lnull) upgrade to `>=3.0.2` More info on how to fix Vulnerable Libraries in [Javascript](https://www.guardrails.io/docs/en/vulnerabilities/javascript/using_vulnerable_libraries.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

codecov[bot] commented 4 years ago

Codecov Report

Merging #127 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          25       25           
  Lines         532      532           
  Branches       29       29           
=======================================
  Hits          521      521           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b9cb81...2acf1ff. Read the comment docs.

jgadsden commented 4 years ago

For some reason PhantomJS is breaking, which then failed the Travis tests. Have switched to using Firefox only until PhantomJS is working again