search

mike-goodwin / owasp-threat-dragon

An open source, online threat modelling tool from OWASP
http://mike-goodwin.github.io/owasp-threat-dragon/
Apache License 2.0
481 stars 130 forks source link

Request to relax test case requirements #68

Closed subashsn closed 4 years ago

subashsn commented 6 years ago

We've added Gitlab as a provider along with Github for Threat Dragon. Currently it's functional, but the test cases are failing due to ES6 syntax and changes done to accomodate multiple providers; Github and Gitlab. Can we relax this?

If this is okay, I'd be happy to raise a pull request that adds Gitlab integration for Threat Dragon. Thanks

Gby56 commented 6 years ago

+1 for the Gitlab integration, I've seen your fork and integrating it in Threat Dragon would boost the popularity. Not sure if Mike is still active for now, but I'm hoping the development goes on

mike-goodwin commented 5 years ago

Hello, apologies for the VERY slow reply. If you're still interested in this project I'd like to work with you to merge your GitLab work, preferably in a way that allows both GL and GH (and in future BitBucket).

subashsn commented 5 years ago

Sure, let's do this. How do we proceed?

jgadsden commented 4 years ago

Hello @subashsn Good to see the gitlab integration at https://github.com/appsecco/owasp-threat-dragon-gitlab Is it possible to combine this back into this original TD repo? Thanks, Jon

jgadsden commented 4 years ago

Migrated to new issue in the OWASP area repo : https://github.com/OWASP/threat-dragon/issues/4