mike-jshen / 2311-Project

Prototype Branch
Creative Commons Attribution Share Alike 4.0 International
1 stars 3 forks source link

Error Detection Bug: Adding a "-" on any line below the first line does not cause error. #17

Closed Martin-Brejniak closed 3 years ago

Martin-Brejniak commented 3 years ago

ID: 17

Author: Martin Brejniak. Contact Info: martin.brejniak@bell.net

Version: March, 17/2021 Version of Software. Platform: Windows 10. Eclipse 4.18.0. JavaSE-13.

Reproduction: I pasted this tab into the text window. I then add a "-" on the left side of the middle "|" on the second row. Expected: I expected to not receive the, "Conversion complete" message, as adding an extra "-" on the left side of the middle "|" on the first row results in the tab not being converted. Actual: The conversion was successful.

Priority: Medium. Severity: With the fantastic error detecting system of the software, a user could become reliant on it. If the user makes a mistake like this, and it doesn't return an error, the user could end up using an incorrect MusicXML. It also states in the user manual that this is an example of an invalid tab (Page 9). Try to have this fixed by the final release.

The tab with an extra "-" added on the left side of the middle "|" on the second row. Converts successfully.

Capture 2

The tab with an extra "-" added on the left side middle "|" on the first row. Does not convert successfully.

Capture
aman9824 commented 3 years ago

That's, the feature we have, It is more robust, if you extra space or any other things, It will neglect it and work fine