mike-jshen / 2311-Project

Prototype Branch
Creative Commons Attribution Share Alike 4.0 International
1 stars 3 forks source link

Grace Tag Not Generated #20

Closed NiharikaRajnish closed 3 years ago

NiharikaRajnish commented 3 years ago

ID #20 Who Raised: Nia Rajnish Title: Grace Tag Not Generated Version: Latest, Master branch Platform: Mac OS, Eclipse, JavaSE-15 Reproduction:

  1. Run the project using the Gradle run
  2. Copy the following text tab into the text panel.

|-----------0-----|-0---------------| |---------0---0---|-0---------------| |-------g0h1----1-|-1---------------| |-----2-----------|-2---------------| |---2-------------|-2---------------| |-0---------------|-0---------------|

grace_note_example.txt

  1. Clicked save and opened output .xml file.

Expected: The system should support grace notes. Any sequence of hammer-ons, pull-offs, or slides that are preceded by the character “g” should be treated as grace notes. Therefore the expected output should include a tag between and for the 4th note(string 3, fret 0).

Actual: The note attribute does not include a grace tag.

Priority: Since this is a system requirement it should be a high priority.

Severity: This bug does not stop or crash the conversion process so it is medium to low severity. Screenshots:

Expected:

Screen Shot 2021-03-24 at 12 14 55 PM

Actual:

Screen Shot 2021-03-24 at 12 16 46 PM
aman9824 commented 3 years ago

Grace Note working now