#132 Change C++ port public API

mike-lischke / antlr4-c3

A grammar agnostic code completion engine for ANTLR4 based parsers

MIT License

396 stars 62 forks source link

#132 Change C++ port public API #146

Closed vityaman closed 1 month ago

vityaman commented 1 month ago

Introduced an optional parameters pack for collectCandidates. Because current API is not so convenient for usage of only a part of arguments.
Did hide preferredRules and ignoredTokens under setters. This will provide us an ability to change internal data structures to improve performance (I'm thinking about using BitSet, because it is more cache friendly while there are not, so many token types in average generated parser).
Renamed some variables.
Raised port version to 2.0.0 because of API breaking changes.

mike-lischke commented 1 month ago

Introduced an optional parameters pack for collectCandidates. Because current API is not so convenient for usage of only a part of arguments.

I believe the term "parameter pack" is used in the context of type parameters, but I know what you mean.

Did hide preferredRules and ignoredTokens under setters. This will provide us an ability to change internal data structures to improve performance (I'm thinking about using BitSet, because it is more cache friendly while there are not, so many token types in average generated parser).

Unnecessary. If you change the storage type (which is really uncritical, both in time and space) let the user know and they can adapt.

vityaman commented 1 month ago

@mike-lischke,

removed setters
made debug options to be a public field with struct type
did tiny refactorings