search

mike-lischke / antlr4ng

Next Generation TypeScript runtime for ANTLR4
Other
85 stars 15 forks source link

Wrong property name #8

Closed EtienneDuv closed 11 months ago

EtienneDuv commented 11 months ago

Problem: Parser's getter syntaxErrorsCount at src/Parser.js:302 is inconsistent with type src/Parser.d.ts:53 syntaxErrorCount. This results in typescript not building unless adding @ts-ignore + autocomplete is wrong

Solution: Change either of them, but I would change the syntaxErrorsCount to syntaxErrorCount to be consistent with antlr4ts

Thanks for your work :)

mike-lischke commented 11 months ago

oh, good find! This should be a no-brainer, once everything is in TypeScript.

EtienneDuv commented 11 months ago

When can I expect the fix ? Just to know, as I wanted to use the lib for work

mike-lischke commented 11 months ago

Hmm, I'm thinking of a new release next weekend, as I have a couple changes in the generator too.

mike-lischke commented 11 months ago

Fixed in 1.1.7