mike-lischke / vscode-antlr4

ANTLR4 language support for Visual Studio Code
http://www.soft-gems.net
MIT License
435 stars 61 forks source link

Add a config variable to allow users to set the Java executable location (fixes issue #57) #273

Closed parkerlamb closed 6 months ago

parkerlamb commented 6 months ago

Fixes issue #57.

This adds a new configuration variable called javaHomeOverride. This allows users to explicitly set JAVA_HOME if it is not present or if they wish to use a different Java installation. The Java executable is looked up at ${javaHomeOverride}/bin/java in this case.

This also changes the default behavior to use $JAVA_HOME/bin/java as the Java executable to be consistent.

If neither of javaHomeOverride or the JAVA_HOME environment variable are set then the extension attempts to launch java in PATH as before.

I'm happy to adjust this as needed, feedback welcome.

mike-lischke commented 6 months ago

You also have to complete the DCO check. Follow the "Details" link to learn how to do that.

parkerlamb commented 6 months ago

Thanks for the comments - I think I've addressed everything

mike-lischke commented 6 months ago

Thanks!

7c00 commented 3 months ago

hi @mike-lischke, could you publish a new release to include this feature?

RedHotUnicorn commented 3 months ago

hi @mike-lischke , we really would like to get an ew release with that feature. thanks