mike-lischke / vscode-antlr4

ANTLR4 language support for Visual Studio Code
http://www.soft-gems.net
MIT License
424 stars 60 forks source link

Various Lint Issues #294

Closed mlshort closed 1 month ago

mlshort commented 1 month ago

This is an effort to share some of the Lint issues encountered and local fixes made to address.

  1. Extra instruction as follows:

FrontEndUtils.tx(250): const info = backend.getContextDetails(document.fileName); 1;

mlshort commented 1 month ago
  1. change of String -> string in the following:

WebviewProvider.ts(32):

export class WebviewProvider { protected currentRule: string | undefined; protected currentRuleIndex: number | undefined;

// Keep track of all created panels, to avoid duplicates.
private webViewMap = new Map<**String**, [WebviewPanel, IWebviewShowOptions]>();
mike-lischke commented 1 month ago

You could create a PR with linter fixes ¯_(ツ)_/¯

mlshort commented 1 month ago

You are correct.

Was not sure you wanted me working directly on your code or not.

:)

mlshort commented 1 month ago

Ok, I have all of the lint errors addressed locally. Only some warnings remain. Will do a PR for your review.

LintWarnings

mike-lischke commented 1 month ago

Addressed by commit 51dacf6