mike-north / ember-c3-shim

Ember-cli shim for c3.js
MIT License
2 stars 4 forks source link

Prepare for ember-cli-fastboot 1.0 build changes #91

Open tsubomii opened 7 years ago

tsubomii commented 7 years ago

Hi Mike, ember-cli-fastboot 1.0 will have backwards incompatible changes. Please see doc here https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c. The motivation for this change is documented here ember-fastboot/ember-cli-fastboot#387

The environment variable EMBER_CLI_FASTBOOTdoesn't exists any more in ember-cli-fastboot 1.0 build. I made the changes in this pull request and verified the build works with ember-cli-fastboot 1.0. However the tests in this repo was already failing without my changes. I don't have enough context about your test senario. Could you please verify on your side with proper use cases?