search

mike-north / ember-cli-materialize

Material Design (via Materialize) for Ember.js Apps
https://mike.works/ember-cli-materialize
MIT License
300 stars 113 forks source link

segfault after installing #454

Open eccegordo opened 7 years ago

eccegordo commented 7 years ago

I have a small example repo that demonstrates a segmentation fault.

The project is using Ember 2.9 beta and glimmer 2. Also have an SVG logo component. Not sure if either of these is the cause or something specific to materialize addon.

Ember.js 2.9 beta1 Ember CLI 2.9 beta1

Steps to reproduce:

- Check out https://github.com/eccegordo/example-svg-logo
- npm install
- bower install
- npm start

Everything works normally

switch to problematic branch

- https://github.com/eccegordo/example-svg-logo/tree/materilize-segfault
- npm install
- bower install
- npm start 

segmentation fault

The only difference between master and materilize-segfault branches is that in the latter I ran 

ember install ember-cli-materialize
eccegordo commented 7 years ago

hmm seems to be related to node-sass but switching back and forth between branches seems to have fixed issue. Not sure if this will be reproducible on your end. Heisenbugs 😄

dustinfarris commented 7 years ago

If this is a new project, you'll probably want to use the v1 branch.

The seg fault should have been fixed on v1 and master though. It was an upstream issue with node-sass resolved over a month ago and brought in here (v1) and here (master), so it's odd that you are getting it still.

dustinfarris commented 7 years ago

ah, might be that master still pegs an old version of ember-materialize-shim which still brings in the old node-sass.

Using the v1 branch should fix this. I guess it should be fixed on master too, if anyone wants to do that.

mattcoker commented 7 years ago

@dustinfarris is this still the best solution? I just added this package to a new project and can't run ember server anymore. I know that this package or a dependency is to blame, as when I switch to a branch without ember-cli-materialize, it works fine

dustinfarris commented 7 years ago

@mattcoker did you install the v1 branch?

ember install "mike-north/ember-cli-materialize#v1"
ember generate ember-cli-materialize
ghost commented 7 years ago

HI @dustinfarris ,

The problem persists, I have done your steps and the result is:

ember install "mike-north/ember-cli-materialize#v1":

Installed packages for tooling via npm. WARNING: Could not figure out blueprint name from: "mike-north/ember-cli-materialize#v1". Please install the addon blueprint via "ember generate " if necessary. Installed addon package.

ember generate ember-cli-materialize:

installing ember-cli-materialize install addons ember-materialize-shim@~0.4.1, ember-cli-flash@^1.3.14, ember-gestures@~0.4.1 Installed packages for tooling via npm. Install failed. Could not find addon with name: ember-materialize-shim@~0.4.1.

it's frustrating...

dustinfarris commented 7 years ago

What version of ember-cli?

Sent from my iPhone

On Nov 1, 2016, at 8:39 PM, Jaider notifications@github.com wrote:

HI @dustinfarris ,

The problem persists, I have done your steps and the result is:

ember install "mike-north/ember-cli-materialize#v1":

Installed packages for tooling via npm. WARNING: Could not figure out blueprint name from: "mike-north/ember-cli-materialize#v1". Please install the addon blueprint via "ember generate " if necessary. Installed addon package.

ember generate ember-cli-materialize:

installing ember-cli-materialize install addons ember-materialize-shim@~0.4.1, ember-cli-flash@^1.3.14, ember-gestures@~0.4.1 Installed packages for tooling via npm. Install failed. Could not find addon with name: ember-materialize-shim@~0.4.1.

it's frustrating...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 7 years ago

ember cli version: 2.9.1 node version: 6.9.1