search

mike-north / ember-material-lite

Material Design Lite for Ember.js Apps
http://mike.works/ember-material-lite
MIT License
148 stars 51 forks source link

SASS compilation is missing vendor prefixes #64

Open hdra opened 9 years ago

hdra commented 9 years ago

I just noticed this issue when I tested my app on Safari few days ago, the page layout went haywire because the styles are missing some prefixes (most noticeably the lack of flexbox support).

Looking at Google's MDL gulpfile.js, I noticed the build process involves feeding the source through an auto-prefixer,, so I got around this by simply installing https://github.com/kimroen/ember-cli-autoprefixer.

So, what do you think about adding an auto-prefixer as a dependency?

mike-north commented 9 years ago

adding that as a dependency would be fine. Can you take care of opening a PR and testing it to make sure things work properly?

leoeuclids commented 9 years ago

@hdra i've done the changes adding the autoprefixer dependency. Is it ok to you if i open a PR?

hdra commented 9 years ago

@leouclids yeah, definitely. Sorry, been busy with a family emergency the past few days.

On Fri, Sep 18, 2015 at 2:43 AM, leoeuclids notifications@github.com wrote:

@hdra https://github.com/hdra i've done the changes adding the autoprefixer dependency. Is it ok to you if i open a PR?

— Reply to this email directly or view it on GitHub https://github.com/mike-north/ember-material-lite/issues/64#issuecomment-141183785 .

Best Regards, and Thank you, Hendra

leoeuclids commented 9 years ago

@hdra no problem, family always comes first.