search

mike-north / jsonapi-typescript

TypeScript type information for JSON:API documents
52 stars 5 forks source link

Add optional meta to DocBase #37

Closed gnapse closed 5 years ago

gnapse commented 5 years ago

Closes #36

See discussion there for details.

gnapse commented 5 years ago

Sorry, not sure how to fix the commit message. I mean, I know how to do it, but I do not know what the rules are to comply with the commitlint. I did not find a contributing guide either.

mike-north commented 5 years ago

Please reword your commit message to 

fix: add optional meta to DocBase

per https://conventionalcommits.org

gnapse commented 5 years ago

Done!

I'd recommend that this should be explicitly stated somewhere. Ideally a CONTRIBUTING.md file in the root of the project (which BTW GitHub notices and highlights its existence to users that are making their first contribution to a repo).

I'm more than happy to make a PR for this as well.

mike-north commented 5 years ago

I'm more than happy to make a PR for this as well. Yes please!

mike-north commented 5 years ago

All this should need is some tests :)

gnapse commented 5 years ago

Yes, sorry, I haven't been able to devote time to it. Thanks for the reminder. Will try to tackle it before next week.

johannesschobel commented 5 years ago

just pushing this upwards @gnapse :laughing:

johannesschobel commented 5 years ago

This can be closed because of #62