search

mike-ward / VSColorOutput

Color highlighting to Visual Studio's Build and Debug Output Windows
MIT License
430 stars 93 forks source link

Infinite Recursion #126

Closed myCrack closed 3 years ago

myCrack commented 3 years ago

https://github.com/mike-ward/VSColorOutput/blob/a7203a92bf85e30c54c261488f7ba7b60a848964/VSColorOutput/State/Settings.cs#L98-L119

https://github.com/mike-ward/VSColorOutput/blob/a7203a92bf85e30c54c261488f7ba7b60a848964/VSColorOutput/State/Settings.cs#L146-L152

Settings.GetSettingsFilePath -> Settings.Save -> Settings.GetSettingsFilePath -> ...

In GetSettingsFilePath, If settingsPath ditn't exist, then, at line 117 invoked method Save on new instance, then again, at line 115 invoked static method GetSettingsFilePath.

mike-ward commented 3 years ago

Well that's not very smart of me...