mike1o1 / ember-material-design

Ember implementation of Google's Material Design
http://mike1234.com/ember-material-design
MIT License
121 stars 15 forks source link

Consolidating efforts? #8

Open SirZach opened 9 years ago

SirZach commented 9 years ago

There's another ember-addon for material design at https://github.com/miguelcobain/ember-paper. @miguelcobain is leading that charge, do you think you would consider consolidating efforts or do you feel that maybe diversity is a good thing?

miguelcobain commented 9 years ago

There is a lot of good work going on here! Too bad this ended up in a different repository. Looks like ember-paper being mentioned at EmberConf/Twitter wasn't enough to catch all the contributors. :smile:

I'm totally up for merging both projects!

mike1o1 commented 9 years ago

Before I started, I remember looking to see if something was similar, and only saw the addon the was a wrapper around Materialize. I created this project more as a learning process for Ember and Angular.

I was already a little over half way through porting before I discovered ember-paper. I'll try and set aside some time to submit pull requests for some of the items which are missing from ember-paper.

mike-north commented 9 years ago

Hey @mike1o1 @miguelcobain @sgasser -- I'm trying to get an accurate gauge of the current state of these three projects. Can you tell if I'm missing anything, or have any incorrect descriptions?

Addon Goal Components
ember-material-design An ember conversion of angular-material bar loader, basic buttons, checks, circular loader, content pane, dividers, flat buttons, floating buttons, icons, inputs, lists, navbar, range, tabs, toasts, tooltip
ember-cli-materialize Idiomatic ember wrappers around MaterializeCSS badges, bar loader, basic buttons, cards, checks, circular loader, collapsible, date picker, flat buttons, floating buttons, footer, icons, input, modal, navbar, pagination, parallax, radios, range, select, sidenav, switches, tabs, textarea
ember-paper A "from scratch" effort to build material design UI elements, following ember idioms as closely as possible basic buttons, card, check, icons, list (collection), navbar, radio, sidenav, switch, textfield
shawndumas commented 9 years ago

+1 on @truenorth 's Q.

elbeezi commented 9 years ago

+1 as well, great idea to map the three projects side by side

razor-x commented 9 years ago

Love that ember is getting some material design love.

I'm just starting to learn Ember so maybe this feedback will help. I tried getting ember-paper going on a "bleeding edge" fresh install of ember, and I ran into some issues (submitted a PR for a 0.2.5 update). Then I tried ember-cli-materialize and it didn't work out of the box. This one however pretty much worked straight away.

miguelcobain commented 9 years ago

@razor-x Ember-cli and Ember itself are being actively developed. With each version, Ember gets a lot of deprecations (which help us move forward). So, addons aren't very stable at the moment. Lots of very popular addons are getting deprecations, partly because they need to target different ember versions. But this is for a good cause, and we'll all be in Ember 2.0 in no time. :)

mike-north commented 9 years ago

@razor-x over the weekend I got ember-cli-materialize working with Ember 1.13-beta.1 (latest meaningful release -- I don't think anyone is even working on the 2.0.0-canary branch yet). It should work "out of the box", so please report any issues you found and I'd be happy to look into them.

peec commented 9 years ago

This repo (ember-material-design) seems to be the most complete material design for now. It has much more features then ember-paper. So I guess it makes sense that this repo will be the one to continue on. And thus it seems like you @mike1o1 are also actively developing this :) I'm going to submit some pull requests soon

Edit: This quote is no longer true. I'm now using ember-paper as implementation wise - it seems like a cleaner approach and more against using ember principles.

jfrux commented 9 years ago

@peec I agree. It's definitely the most functional. Ember paper even has some of the demo not functional. :-/ Sidebar is one.

Some of the other projects are kind of far off from what I'd consider to be material design pattern.

miguelcobain commented 9 years ago

Ember paper even has some of the demo not functional. :-/

@joshuairl Which demos are not functional, specifically? Sidenav works really good for me.

jfrux commented 9 years ago

Hmm… one of them was Sidenav but it’s working now… not sure maybe was just a fluke in page load.

Sorry!

On Jul 24, 2015, at 9:24 AM, Miguel Andrade notifications@github.com wrote:

Ember paper even has some of the demo not functional. :-/

@joshuairl https://github.com/joshuairl Which demos are not functional, specifically?

— Reply to this email directly or view it on GitHub https://github.com/mike1o1/ember-material-design/issues/8#issuecomment-124519313.

jfrux commented 9 years ago

None of them are that great on mobile browsers… but not sure if that was the intent to be mobile compatible.

On Jul 24, 2015, at 9:26 AM, Joshua Rountree joshua@remote-app.com wrote:

Hmm… one of them was Sidenav but it’s working now… not sure maybe was just a fluke in page load.

Sorry!

On Jul 24, 2015, at 9:24 AM, Miguel Andrade <notifications@github.com mailto:notifications@github.com> wrote:

Ember paper even has some of the demo not functional. :-/

@joshuairl https://github.com/joshuairl Which demos are not functional, specifically?

— Reply to this email directly or view it on GitHub https://github.com/mike1o1/ember-material-design/issues/8#issuecomment-124519313.

miguelcobain commented 9 years ago

@joshuairl File issues if you see something isn't working as supposed, mobile or desktop.

@mike1o1 and me agreed to merge both projects.

jfrux commented 9 years ago

Which one will be the standard format? Don’t want to build an app with {{paper-}} prefixes then swap everything to {{md-}}

Just trying to decide soon on which to move on.

You guys rock!

On Jul 24, 2015, at 9:29 AM, Miguel Andrade notifications@github.com wrote:

@joshuairl https://github.com/joshuairl File issues if you see something isn't working as supposed, mobile or desktop.

@mike1o1 https://github.com/mike1o1 and me agreed to merge both projects.

— Reply to this email directly or view it on GitHub https://github.com/mike1o1/ember-material-design/issues/8#issuecomment-124520740.

miguelcobain commented 9 years ago

@joshuairl I'm pretty sure that changing {{paper- to {{md- or vice-versa isn't a problem.

I'd say use whatever suits you best for now. From my conversation with @mike1o1, ember-paper has probably a larger user base and will probably be the repository to hold everything.

mike-north commented 9 years ago

@miguelcobain you can always export components more than once from the addon tree to the app tree. This would probably be the gentlest approach on your users, because you could slowly deprecate your way to where you want to go, rather than asking them to make an abrupt transition.

DanChadwick commented 8 years ago

Of the three materially-similar ;) projects, as of this writing, ember-paper seems to be receiving the most development activity and is probably the most feature-complete at this point. I and others have been working on getting dialogs fully functional. Tabs are also being added.

ember-paper uses directly parsed versions of the angular style sheets. This lets the project stay updated with the Angular project, and also ensures that the SCSS all comes from the same version of the Angular material.

The ember-paper contributors are working their way through the elements in the master branch, porting them to the latest ember coding standards, and updating them for ember 2.3+. This effort is taking place in the wip/v1.0.0 branch.

Angular has just announced a version 2, which will not be backward compatible with the version 1 style sheets. If version 2 is supported by the ember community, it will be a large body of work to reproduce.

I am wondering if there is some development talent from ember-material-design and ember-cli-materialize that could be diverted to ember-paper so that we can have one really great implementation, rather than 3 competing sorta-good implementations. The ember community is much smaller than the angular community, and working divided exacerbates the disparity in resources.

The ember-paper folks seem to hang out on slack on #ember-paper.

Having a few extra developers helping out could get us one really great material design implementation. Any takers?

nucleartide commented 8 years ago

:+1: for unification. I think it's a waste of time to have three competing implementations, there should be a single Ember/Material Design toolkit that rivals Bootstrap in quality and breadth of use cases. Devs shouldn't have to choose.