search

mike1pol / drone-rocket

Drone plugin for sending message to Rocket.Chant channel using API.
4 stars 2 forks source link

Plugin doesn't send messages anymore #2

Closed joseluisq closed 3 years ago

joseluisq commented 3 years ago

This plugin is not sending messages anymore because Content-type: application/json missing header during client request.

https://github.com/mike1pol/drone-rocket/blob/7cc780ad8df0fbf2429e5a7e4a8d64aa41a1a141/plugin.go#L151-L157

Also err check should be before the defer.

BTW I did a fork at https://github.com/joseluisq/drone-rocketchat because I wanted that fix ASAP. However since I don't intend to support it so It would be great if you can address this issue in order to be able to continue using this plugin. Or let me know if you are interested in a PR for that particular fix.

mike1pol commented 3 years ago

PR Welcome

joseluisq commented 3 years ago

Thanks for the invitation. A PR should come in coming hours.