search

mike2611 / portfolio

In this project, I set up a portfolio to display some of my projects.
5 stars 0 forks source link

Peer-to-peer code review - 31/08 #10

Closed dicodiaz closed 2 years ago

dicodiaz commented 3 years ago

Hello @mike2611, this issue is for feedback on the morning session peer-to-peer code review on 31/08.

KatIsCoding commented 3 years ago

Pretty good job so far!! 🎉🎉

Your project have none or almost no errors so it is kinda hard to review yours since I don't have almost any suggestion (anyways that's great haha)

A small suggestion I would do is, instead of creating new CSS classes for display: none and display: flex what about using them inside your javascript so you don't have to "toggle".

Other than that, great job!

Gif

ramiaquista commented 3 years ago

Awesome Project! 😄

I think it would be a good idea if you avoid committing empty files to make it cleaner and easier for one who has to read!

Screen Shot 2021-08-31 at 11 24 32 AM

You have done a great job, keep up coding! 🎉 🎉

cat-gift

dicodiaz commented 3 years ago

Outstanding job! I have nothing to suggest for your last project's code.

However, I would recommend adding more information to your README file to make it more professional. You can find a really professional README from one of our more advanced fellow Microverse students here.

Keep up the good work!

mike2611 commented 2 years ago

Thanks, partners I already applied your recommendations