search

mike820324 / microProxy

A http/https interceptor written in pure python.
MIT License
17 stars 3 forks source link

Gviewer upgrade #169 #172

Closed chhsiao90 closed 8 years ago

chhsiao90 commented 8 years ago

Resolved #169

chhsiao90 commented 8 years ago

Please enjoy it~

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 71.176% when pulling 70a21aec3aa0cadfa37bea9181a22f93ed644b5d on gviewer-upgrade-#169 into 1f9974388c7bc5304f2169a2df81a7c13bf39ace on master.

mike820324 commented 8 years ago

Good work. One thing to ask is that the urlencoded json/xml format, does not apply the pygments highlight. Is is the expected behaviors?

chhsiao90 commented 8 years ago

Yes, currently, which lexer to be used is depends on which formatter is used.

chhsiao90 commented 8 years ago

Currently, the pygments is implement in tui, so the only thing tui could know is which formatter used to format the body. I would try implement it in formatter so that it will colorized the body more correctly. But maybe it would wait for the gviewer upgrade merged

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 71.176% when pulling 1cc84936134e5e2bf06bfd0de052111b8ebf5c1e on gviewer-upgrade-#169 into d5cafa85b1660bb640f571573d8ff5ebc946706f on master.

mike820324 commented 8 years ago

LGTM, is it still WIP?

chhsiao90 commented 8 years ago

No, ready to merge Previous push is just for rebase

mike820324 commented 8 years ago

Merged, thanks.