Refactor socks layer and enhance unittet

mike820324 / microProxy

A http/https interceptor written in pure python.

MIT License

17 stars 3 forks source link

Refactor socks layer and enhance unittet #184

Closed chhsiao90 closed 8 years ago

chhsiao90 commented 8 years ago

Had refactor socks layer, please give me feedback if any, thanks!

coveralls commented 8 years ago

Coverage increased (+1.2%) to 72.321% when pulling 9d6892fca912a8e2d245fadcd09faefce07e94f3 on socks-refactor into f7f20fe8e6cc2b8b310f7e42a4337e8120df2958 on master.

mike820324 commented 8 years ago

Interesting PR, based on the diff it seems like you rewrite the socks layer.

chhsiao90 commented 8 years ago

Updated and rebased

The major change of this PR is remove the return of tuple (error, event) and let the handle_greeting_request , handle_request_and_create_destination to send event and raise Exception.

coveralls commented 8 years ago

Coverage increased (+1.2%) to 72.742% when pulling 8f21e7c70779ced4ad92be623533b5e76c259876 on socks-refactor into 97d2186ccb41f3ae6f7d5eb13009da0c7f205dee on master.

mike820324 commented 8 years ago

Sorry for taking so long. LGTM now.