Closed mike820324 closed 7 years ago
@chhsiao90 Help me review thanks.
I will update unittest for server state later.
Great work! LGTM~
Had some suggestion about the global state of server_state. (Global state is hard to maintain!) How I think to remove the global state of server_state
server_state.py
(init_server_state just return ServerContext
, don't keep the instance) CodeReferenceServerContext
to ProxyServer
in proxy.py as its initialize field CodeReferenceProxyServer
CodeReferenceAnd the layer_manager
in ProxyServer
I think we could remove self.layer_manager = layer_manager
in __init__
method.
Because layer_manager had changed from object to a module, it's not object anymore, so I think there is no need to assign it to ProxyServer as its field.
How do you think :)
@chhsiao90 I have modified the code based on the previous review.
Thanks. You have used the new github feature. XD
Yeah, it's cool~ XD
There is no reject options, so sad...
Don't reject me\ QAQ/
init_server_state
andget_server_state