Resolved #204: Display TLS Information

mike820324 / microProxy

A http/https interceptor written in pure python.

MIT License

17 stars 3 forks source link

Resolved #204: Display TLS Information #208

Closed chhsiao90 closed 7 years ago

mike820324 commented 7 years ago

That is quick, I'll take some time to review this. Thanks.

chhsiao90 commented 7 years ago

Refs: #204

mike820324 commented 7 years ago

Force push due to v0.4.1 hotfix release.

Should fix the test failed.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 78.014% when pulling 8af638730f7ced212d83b87fa20224d08034080f on tls-info-#204 into acf48c8790c61daf6c905a159bc8f063bf37b90b on master.

chhsiao90 commented 7 years ago

LGTM, the Serializable class looks really good. Just one question.

Any reasons to add the kwargs to HttpRequest, HttpResponse, TlsInfo and ViewContext. Backward compatible?

Yes, for backward compatibility!