Resolved #218: add default value for mpdump.

mike820324 / microProxy

A http/https interceptor written in pure python.

MIT License

17 stars 3 forks source link

Resolved #218: add default value for mpdump. #219

Closed mike820324 closed 7 years ago

mike820324 commented 7 years ago

Add default value for the following options.

proxy-host
event-channel
viewer-channel

mike820324 commented 7 years ago

@chhsiao90 Please review, thanks.

coveralls commented 7 years ago

Coverage remained the same at 78.014% when pulling 2bd94af41e0d49aa5beb57ea654459b67de85376 on mpdump-default-option-#218 into 320fde3ff7ee2bdac3946dc328abf42a3aa15fb7 on master.

chhsiao90 commented 7 years ago

Should tui-viewer had same config argument as console? tui-viewer had viewer-channel and event-channel but console-viewer had host, viewer-port, event-port

mike820324 commented 7 years ago

Good point, we should open an issue discussing this part.

mike820324 commented 7 years ago

Or just using the same issue, I'll change the title of the issue and change the PR into WIP

mike820324 commented 7 years ago

I'll merged this first and fire another issue discussing the mpdump interface.