Fix proxy error when connecting to https.

mike820324 / microProxy

A http/https interceptor written in pure python.

MIT License

17 stars 3 forks source link

Fix proxy error when connecting to https. #230

Closed mike820324 closed 7 years ago

mike820324 commented 7 years ago

The previous refactor forgot to remove some of the code, causing the proxy error when connecting to https.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 85.449% when pulling 6dc0cc98398f62465a48252e6f9705465dbebbab on fix-tls-failed into 7ecd4c8936034f8e0d751da4f3519728de7ba178 on master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 85.927% when pulling 7f0910893e9d3086ac85047b5a25060dd2f93888 on fix-tls-failed into 7ecd4c8936034f8e0d751da4f3519728de7ba178 on master.

mike820324 commented 7 years ago

@chhsiao90 this is a quick fix, but the reason this problem occur is that I forgot to add the unit test for layer.tls. Orz

Sorry bout that.

chhsiao90 commented 7 years ago

LGTM sorry for bring this bug into code :(

mike820324 commented 7 years ago

No, it's my bad. I have missed the unittest for this part and I should find out this regression when I review the code.

Thanks. :)