mike820324 / microProxy

A http/https interceptor written in pure python.
MIT License
17 stars 3 forks source link

Socks upgrade #237

Closed mike820324 closed 7 years ago

mike820324 commented 7 years ago

This PR upgrade socks5 to v 0.2.1.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.01%) to 86.449% when pulling 4ab4a108b600c7483cc0941125b2fac543973e69 on socks-upgrade into ddbacbae127517790c9e00c2eba40b713d2877d8 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 86.891% when pulling b1639d217e3a57c1edbac35e392261b8043e3301 on socks-upgrade into ddbacbae127517790c9e00c2eba40b713d2877d8 on master.

mike820324 commented 7 years ago

Hi @chhsiao90, help me review this, tks.

chhsiao90 commented 7 years ago

Wow, the option Changes requested of code review is cool~

mike820324 commented 7 years ago

Will do, I'll push a new commit later.

mike820324 commented 7 years ago

Thanks for the review. The new code review functionality is really good, except I forgot to press submit. Orz

mike820324 commented 7 years ago

Fix based on review, thanks.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 86.891% when pulling 1dffc2966d3d6a1817790432b8f08a0540a07274 on socks-upgrade into ddbacbae127517790c9e00c2eba40b713d2877d8 on master.