fix various bugs - Githubissues

mikeal / SLEEP

Implementation of the SLEEP protocol.

29 stars 6 forks source link

fix various bugs #4

Closed max-mapper closed 11 years ago

max-mapper commented 11 years ago

this pull request:

adds object mode, which is {"rows": []} (returning arrays to certain versions of IE exposes a json parsing security vulnerability)
fixes all modes to work when the database is empty. previous newline mode returned \nundefined and array mode returned ]
adds ability to pass in default options for SLEEPStream to the SLEEP constructor
emits errors on the sleep client stream (this was broken)

mikeal commented 11 years ago

i'm starting to think that getSequences needs to be a stream in "object mode". i've already run in to some memory issues when pulling a SLEEP feed and writing more new data than i'm reading.

max-mapper commented 11 years ago

yea I dont think there is a valid use case for a non streaming mode. if you want to aggregate all changes you can just use concat-stream or something

mikeal commented 11 years ago

it was mostly there to simplify for the code the "lower common denominator" case of serializing an object.