search

mikeal / ipjs

Universal JavaScript Build and Packaging
41 stars 4 forks source link

fix!: don't delete "main" in package.json #7

Closed rvagg closed 3 years ago

rvagg commented 3 years ago

esbuild still doesn't support exports https://github.com/evanw/esbuild/issues/187 it's uncertain as yet what impact this might have on other bundlers and loaders, hence this is a BREAKING CHANGE.

mikeal commented 3 years ago

This won’t work on its own, the built package doesn’t have an index.js in the root, it has two directories for the esm and cjs builds, we’ll need to re-write this to ‘cjs/index.js’.

rvagg commented 3 years ago

doh! of course .. and I even did this for a pkg I manually fixed & published. I've pushed a fixup commit that does this, it should be squashed in if/when merged.