Closed benwinding closed 4 years ago
@benwinding thank you for putting this together! Conceptually it looks like exactly what I'm looking for; I'm using pika/pack for my tooling, which builds the package in a pkg/
subfolder.
I'm trying to use your branched version in my project, but it doesn't appear to be working:
Using this approach, my NPM packages still are published at the root:, instead of the subfolder I want https://unpkg.com/browse/bt-device@1.0.2/
Looking at the Action's entrypoint, I think this is because it's using the NPM version of merge-release
when actually being used by a component:
https://github.com/mikeal/merge-release/blob/master/entrypoint.sh#L31
Which makes me thing this PR needs merged and published for folks to actually use 🙃
@mikeal can you confirm? Is there anything I can do to help get this merged?
pinging @fredkschott who might find this interesting.
Apologies, I didn’t see the last commit come in after my last review comment. This shouldn’t have sat here for so long, my bad.
Scope Added functionality for deploying a package within a subdirectory in a monorepo. Similar to PR #7, but here's my changes anyway...
Features In mono repos the
src
directory and compileddist
directory are usually in different folders. So I added the 2 environment variables:SRC_PACKAGE_DIR
(where the src package.json is to increment)DEPLOY_DIR
(where the dist package.json is to runnpm publish
)In angular development it's convention to use a projects folder for the src code and a dist folder for the builds.
Here's a working snippet using a forked version of this repo:
Cheers for making this anyway, hope this PR helps someone else :+1: