search

mikeal / merge-release

Automatically release all merges to master on npm.
Other
471 stars 64 forks source link

fix: log errors rather than allowing unhandled rejections #2

Closed jlipps closed 4 years ago

jlipps commented 4 years ago

i always do this, not sure if you like this pattern. just a drive-by while reading the code :-)

mikeal commented 4 years ago

in Node.js won’t the error already be as an unhandled async error? does this make it look any nicer? usually when you console log error instances they don’t actually give you the trace

jlipps commented 4 years ago

You do get the trace (at least so far as I can tell in the Node versions I use). The only thing you don't get is the few lines that discuss the unhandled promise rejections. It is a very small difference.

mikeal commented 4 years ago

that sounds much nicer, i’ll merge it