search

mikeal / merge-release

Automatically release all merges to master on npm.
Other
471 stars 64 forks source link

Support `!:` commit syntax for breaking changes #26

Closed mikeal closed 3 years ago

mikeal commented 4 years ago

The current rules only support the old “BREAKING” message. Conventional commits added a “fix!:” and “feat!:” for signaling breaking changes. We should just parse for “!:” for a major version bump.

honzabilek4 commented 3 years ago

Hello @mikeal, not everyone uses conventional commits. Can we make these keywords configurable, so everyone can adjust it to their liking? I would like to submit a PR for that.

mikeal commented 3 years ago

i’d like the interface to be stable and consistent. it’s not that i’m adamant that people use conventional commits, i just don’t think this will be a very maintainable project if we start allowing that level of customization. i feel the same way about configuring whether or not every commit releases or just some, the consistency is part of the interface and keeps the usage simple.

there’s plenty of other projects for doing releases though, many of which are highly configurable like https://github.com/googleapis/release-please

honzabilek4 commented 3 years ago

Okay, I'll use some other action instead.

Sergio6690 commented 2 years ago

  1. zz