Closed josejulio closed 3 years ago
@mikeal wondering if this is something that you would like to get in, or if you need more information on the use-case. If so, I would rebase and proceed.
Thanks!
Sorry, I hadn’t seen this come in and just got around to reviewing it.
I’m a little concerned with this. First of all, that’s a lot of code now in the try block, any number of errors will now cause it to skip releasing.
Also, I’m wondering why this would be the preferred behavior rather than using github action filters to not run the action at all unless certain files are changed?
Also, I’m wondering why this would be the preferred behavior rather than using github action filters to not run the action at all unless certain files are changed?
Ah, I didn't know about that possibility: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-paths
Looks like that's the way to go, thanks!
Also, I’m wondering why this would be the preferred behavior rather than using github action filters to not run the action at all unless certain files are changed?
I got in a situation today that these changes would be valid/useful.
I have some packages on a monorepo that I want to release independently, so I have one workflow for each. The thing is that I pushed some code that affected the package and the workflow. There was an error in release-workflow and the package didn't got published. My only options now are:
a) Manual release b) Push some dummy changes to trigger the release workflow again
Something like this is useful in that scenario as I could fix the workflow and push again, besides I could define an env for the path and that would save me having workflow per package.
Thoughs @mikeal ?
This restrict the commits that are inspected to only the ones that have the specific path.
My use-case is the following:
I'm managing a mono-repo which has two packages:
package-1
andpackage-2
. What I want to accomplish is to avoid "BREAKING CHANGE" commits ofpackage-1
to increase the major version ofpackage-2
. As a bonus, this would also prevent releases frompackage-1
when the commits only touchedpackage-2
files.