search

mikeal / merge-release

Automatically release all merges to master on npm.
Other
475 stars 65 forks source link

Version tags are not pushed #45

Open tobyjsullivan opened 2 years ago

tobyjsullivan commented 2 years ago

The docs mention that tags should be pushed to the repo automatically. https://github.com/mikeal/merge-release/blob/7f590a5adf6e9def8e399a0a569d22d0de016dc0/README.md?plain=1#L22

We're currently not seeing any tags pushed to our private repo when the action runs. I don't see anything in the docs about special configuration for pushing repo tags. Am I missing some sort of configuration to get tags working?

I'm looking at the code, and it looks like this part is simply commented out. Is that right?

https://github.com/mikeal/merge-release/blob/7f590a5adf6e9def8e399a0a569d22d0de016dc0/src/merge-release-run.js#L97-L101

kf6kjg commented 2 years ago

Wow, looks like that was disabled as part of a debugging operation a longtime ago: https://github.com/mikeal/merge-release/commit/0cdb164c0bc07218f3945603f8f2a49260396e12

Of course the work-around is simple, just push the tags:

      - name: Publish
        uses: mikeal/merge-release@master
        # ... etc...

      - name: Push generated git tags
        run: |
          git push --tags
alvarolorentedev commented 1 year ago

solved in https://github.com/Github-Actions-Community/merge-release