search

mikeal / merge-release

Automatically release all merges to master on npm.
Other
471 stars 64 forks source link

Support for Private/Restricted Repos and Packages #8

Open Jonjoe opened 4 years ago

Jonjoe commented 4 years ago

Hi!

Loving this repo so thank you for creating it.

Currently this will always push public releases which unfortunately means it cannot be used for private/restricted packages. I've written in some simple support for private/restricted packages by checking against an EnvVar and assigning the access level in the NPM public command.

Its untested as im not actually sure how to develop/test GitHub Actions. However, the logic is super simple so i'm hoping this will be easy to resolve!

I have also added the new EnvVar in the example yml file.

Please let me know if ive missed anything I will be happy to add it in.

Thanks again :)

mikeal commented 4 years ago

Its untested as im not actually sure how to develop/test GitHub Actions. However, the logic is super simple so i'm hoping this will be easy to resolve!

Ya, I haven’t found a sufficient way to test changes in this library so there’s no expectation that contributions need to include them. I’ve just been augmenting the lack of available testing by spending more time on reviews.

Jonjoe commented 4 years ago

Thanks, man, apologies, I haven't had a chance to sort these changes. Will do them asap.

mikeal commented 4 years ago

No worries, there’s no pressure on my end since I don’t need this feature yet 😉

alvarolorentedev commented 10 months ago

merged in https://github.com/Github-Actions-Community/merge-release