search

mikeal / node.couchapp.js

Utility for writing couchapps.
Apache License 2.0
406 stars 78 forks source link

Don't play the horn on push #86

Closed isaacs closed 10 years ago

isaacs commented 10 years ago

I use this for the npm registry, and the horn blow gets incredibly annoying when running tests.

So much so, in fact, that it is a disincentive to create or run tests for the npm registry couchapp, leading to production downtime for the entire Node.js community.

Please consider removing it.

An alternative may be to allow the user to specify a sound file to play on push. But really, this is an unnecessarily presumptuous and literally noisy feature. I can understand the benefit if you had a background sync running, but even then, since sync's usually take less than a second, you can usually just assume it worked.

isaacs commented 10 years ago

Also, if you install afplay on a Linux machine, it will fail, because it only checks for the binary, not the sound file.

mikeal commented 10 years ago

:P

bajtos commented 10 years ago

@mikeal any ETA on when the next version is released? I am using this module in my unit tests too and the sound is super annoying.

mikeal commented 10 years ago

released couchapp@0.11.0