search

mikeal / znode

Bi-directional RPC through any stream.
206 stars 13 forks source link

Handle msgpackStream error #6

Open kumavis opened 6 years ago

kumavis commented 6 years ago

just encountered this again - internal stream error is unhandled and stream is not exposed

mikeal commented 6 years ago

Is the error a bug in our use of msgpack, the msgpack module itself, or a predictable stream error on some kind of disconnect?

I'm trying to figure out the best way to fix this.

On Wed, Jul 4, 2018, 11:11 AM kumavis notifications@github.com wrote:

just encountered this again - internal stream error is unhandled and stream is not exposed

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mikeal/znode/issues/6#issuecomment-402537179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACQ-IOWHRbxormRfeqK9_PmQs5pto6ks5uDQVmgaJpZM4SeENB .

mikeal commented 6 years ago

BTW, I remember encountering some stream errors in msgpack early in development and they were actually bugs in my use of msgpack. That's why I want to flush out what these errors are before we just expose the stream and potentially punt on any potential bugs in znode.