search

mikealmond / MusicBrainz

A PHP library to access MusicBrainz's Web Service v2
http://musicbrainz.org/doc/Development
MIT License
64 stars 26 forks source link

Getters for protected variables from Artists class #10

Open mkovalch opened 10 years ago

mkovalch commented 10 years ago

Not exactly an issue, but is there way to access private variables in search() result; for example: [type:MusicBrainz\Artist:private] => Group [sortName:MusicBrainz\Artist:private] => AFI [gender:MusicBrainz\Artist:private] => [country:MusicBrainz\Artist:private] => US [beginDate:MusicBrainz\Artist:private] => 1991 [endDate:MusicBrainz\Artist:private] => [data:MusicBrainz\Artist:private] => Array

There are functions getName(), getScore(), getType(), getRelease() in Artists class, but i didn't find getGender(), getCountry() and so on.

Is there a different way to get this information? I can add my own methods, but this will get reset on next composer update :( Am I missing something?

mikealmond commented 10 years ago

You are not missing anything. I built this library to use with a personal project and have been adding things as I need them.

If you want to add those methods and create a pull request it would be greatly appreciated!

I hope to spend more time on this library in the upcoming weeks.