Add compatibility with guzzle 6.3.0

mikealmond / MusicBrainz

A PHP library to access MusicBrainz's Web Service v2

http://musicbrainz.org/doc/Development

MIT License

64 stars 26 forks source link

Add compatibility with guzzle 6.3.0 #29

Open TJSoler opened 7 years ago

TJSoler commented 7 years ago

I haven't modified the composer file, but as guzzle 6.3.0 requires PHP 5.5, this adapter will break without that version of PHP.

Besides that, I'm going to be using this library pretty extensively for the next couple of months, would you be open to a modernization of the code? I would try to create some PRs to move to PHP 7.x, write some tests, clean the methods a little, etc.

mikealmond commented 7 years ago

@TJSoler, absolutely. I haven't had any time recently to work on this project (I was using it on a side-project that didn't go anywhere).

I'm open to dropping support for the old Guzzle client in favour of the latest.

TJSoler commented 7 years ago

I can rework this PR into dropping support for old guzzle, setting this up as a default (with examples and readme updates) and setting up travis to check on 5.5+.

We can start from there if you like.

iainmullan commented 6 years ago

Hi @TJSoler - i'm looking to use this library in a PHP 7.2 environment at the moment... happy to help to test/continue development on this branch. What's the best way for me to get this fork via composer? Thanks!