search

mikealmond / MusicBrainz

A PHP library to access MusicBrainz's Web Service v2
http://musicbrainz.org/doc/Development
MIT License
64 stars 26 forks source link

browseReleaseGroup parameter order #37

Open lachlan-00 opened 10 months ago

lachlan-00 commented 10 months ago

getting this php error semi-regularly

2 tests triggered 3 PHP deprecations:

1) /home/scrutinizer/build/vendor/mikealmond/musicbrainz/src/MusicBrainz/MusicBrainz.php:492
Optional parameter $limit declared before required parameter $includes is implicitly treated as a required parameter

2) /home/scrutinizer/build/vendor/mikealmond/musicbrainz/src/MusicBrainz/MusicBrainz.php:0
Optional parameter $offset declared before required parameter $includes is implicitly treated as a required parameter

https://github.com/mikealmond/MusicBrainz/blob/98d1aa1c57dbb609d71db9d3d1487a5729f149de/src/MusicBrainz/MusicBrainz.php#L497C8-L497C25

public function browseReleaseGroup(
        $entity,
        $mbid,
        $limit = 25,
        $offset = null,
        array $includes,
        $releaseType = array()
    ) {

probably just need to add the array?

array $includes = array(),

lachlan-00 commented 10 months ago

sorry i closed thinking i'd made a mistake