search

mikealmond / MusicBrainz

A PHP library to access MusicBrainz's Web Service v2
http://musicbrainz.org/doc/Development
MIT License
64 stars 26 forks source link

0.2 - More features #6

Closed mikealmond closed 10 years ago

mikealmond commented 11 years ago

Biggest change is passing the MusicBrainz object into the entity's constructor. This gives each entity the ability to easily do browsing and lookups for missing data.

It also includes a fix for searches with spaces in them and a protected args array to exclude arguments that should not be Lucene escaped.

:shipit: Shipit?

/ping @Jbekker, @naxxfish

Jbekker commented 11 years ago

Looks good to me!

naxxfish commented 11 years ago

How handy! Looks good to me ... On Nov 14, 2013 2:35 PM, "Mike Almond" notifications@github.com wrote:

Biggest change is passing the MusicBrainz object into the entity's constructor. This gives each entity the ability to easily do browsing and lookups for missing data.

It also includes a fix for searches with spaces in them and a protected args array to exclude arguments that should not be Lucene escaped.

[image: :shipit:] Shipit?

/ping @Jbekker https://github.com/Jbekker, @naxxfishhttps://github.com/naxxfish

You can merge this Pull Request by running

git pull https://github.com/mikealmond/MusicBrainz develop

Or view, comment on, or merge it at:

https://github.com/mikealmond/MusicBrainz/pull/6 Commit Summary

  • Update contact information
  • Bump version number
  • Remove duplicate require statement in composer.json
  • Add helper methods, code cleanup
  • Wrap a query parameter in brackets if a space is present
  • Cleaned up the examples and added some comments
  • Add a more in-depth example
  • Remove extra colon and fix @return tag
  • Added some comments and fixed some bugs

File Changes

  • M LICENSE.mdhttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-0(2)
  • M composer.jsonhttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-1(12)
  • M examples/browse.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-2(26)
  • A examples/first-recording-search.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-3(71)
  • M examples/lookup.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-4(22)
  • M examples/search.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-5(48)
  • M src/MusicBrainz/Artist.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-6(115)
  • M src/MusicBrainz/Collection.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-7(22)
  • M src/MusicBrainz/Country.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-8(11)
  • M src/MusicBrainz/Exception.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-9(4)
  • M src/MusicBrainz/Filters/AbstractFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-10(67)
  • M src/MusicBrainz/Filters/ArtistFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-11(23)
  • M src/MusicBrainz/Filters/FilterInterface.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-12(20)
  • M src/MusicBrainz/Filters/LabelFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-13(14)
  • M src/MusicBrainz/Filters/RecordingFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-14(30)
  • M src/MusicBrainz/Filters/ReleaseFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-15(18)
  • A src/MusicBrainz/Filters/ReleaseGroupFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-16(62)
  • M src/MusicBrainz/Filters/TagFilter.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-17(14)
  • M src/MusicBrainz/Label.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-18(21)
  • M src/MusicBrainz/MusicBrainz.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-19(483)
  • M src/MusicBrainz/Recording.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-20(110)
  • M src/MusicBrainz/Release.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-21(77)
  • M src/MusicBrainz/ReleaseGroup.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-22(47)
  • M src/MusicBrainz/Tag.phphttps://github.com/mikealmond/MusicBrainz/pull/6/files#diff-23(13)

Patch Links:

mikealmond commented 10 years ago

Merged and tagged