search

mikeb26 / ONIMods

Mods for Klei's Oxygen Not Included
MIT License
0 stars 0 forks source link

Idle notification shown for rocket passengers #1

Open llunak opened 1 year ago

llunak commented 1 year ago

I have a rocket with a pilot also taking along two passengers. I get "Idle(2)" notification for those 2 passengers (but not for the pilot).

I'm not sure why this is happening. Those passengers don't even have the piloting skill, but I doubt that's relevant. Maybe their idle notifications started when the pilot was still busy getting the ship to launch, so the suppression didn't at that point detect the rocket as flying, but it was detected when the pilot's notification would be shown?

mikeb26 commented 1 year ago

@llunak sorry I missed your message until just now. are you able to reproduce? if non-pilot dupes enter a grounded rocket, become idle in the rocket, and then the rocket takes off, then yes I would expect the Idle notices to remain posted. I've got a @todo to catch this case where rockets are taking off, landing, stop/start harvesting to take a look at existing idle notices & clear them:

https://github.com/mikeb26/ONIMods/blob/main/IdleNotificationTweaks/GameState.cs#L163

To workaround this you should be able to just move a dupe inside of a rocket and then the new idle notice shouldn't post.