mikeblazanin / gcplyr

gcplyr is an R package that facilitates wrangling and analysis of microbial growth curve data
https://mikeblazanin.github.io/gcplyr/
Other
30 stars 2 forks source link

Return handling when all values are NA for find_local_extrema and find_threshold_crosses #108

Closed mikeblazanin closed 1 year ago

mikeblazanin commented 1 year ago

When all values are NA and na.rm = TRUE, find_threshold_crosses returns a non-intelligible error instead of NA or an intelligible error. Perhaps behavior should be to warn and return NA?

I haven't checked how find_local_extrema handles it but I imagine probably also doesn't handle well.

Should also create tests for this case

mikeblazanin commented 1 year ago

done in v1.1.0.9001