Failure with CRAN gcplyr and dev waldo

[hadley]

I see the following because waldo now correctly distinguishes between NA and "NA":

── Failure ('test_designfunctions.R:75:3'): make_design works for multiple design elements ──
make_design(...) (`actual`) not equal to data.frame(...) (`expected`).

`actual$name`:   "NA" "NA" "NA" "NA" "NA" "1" "NA" "NA" "NA" "a" and 6 more...
`expected$name`: NA   NA   NA   NA   NA   "1" NA   NA   NA   "a" ...          

     actual$name2 | expected$name2               
 [1] "NA"         - NA             [1]           
 [2] "NA"         - NA             [2]           
 [3] "NA"         - NA             [3]           
 [4] "NA"         - NA             [4]           
 [5] "NA"         - NA             [5]           
 [6] "a"          | "a"            [6]           
 [7] "NA"         - NA             [7]           
 [8] "NA"         - NA             [8]           
 [9] "NA"         - NA             [9]           
[10] "hello"      | "hello"        [10]          
 ... ...            ...            and 6 more ...

[ FAIL 1 | WARN 0 | SKIP 0 | PASS 170 ]

But I can't recreate the problem locally with the dev version of gcplyr, so it's possible that you've fixed it in dev. This means you might want to do a patch release soon to avoid failure when I release waldo.

[mikeblazanin]

Ah yep, this is a bug that's been fixed in the dev version on Github. I'll release that version to CRAN shortly

[hadley]

Thanks!

[mikeblazanin]

1.5.0 submitted to CRAN