search

mikeboers / Flask-Images

On-demand resizing of images for Flask applications.
https://mikeboers.github.io/Flask-Images/
BSD 3-Clause "New" or "Revised" License
81 stars 43 forks source link

Chenged context_processor to template_global and some PEP8 fixes #4

Closed rochacbruno closed 10 years ago

rochacbruno commented 10 years ago

I changed context_processor to app.add_template_global. context processor adds more complexity to request pipeline, template_global is injected in jinja level.

Fixed "line too long" and "space before operator" PEP8 errors.

mikeboers commented 10 years ago

Sounds good in theory, but after working far too long today I'm not able to mentally separate the PEP8 stuff from the context_processor -> template_global change.

If it is easy for you to do so, can you separate them? Otherwise, give me a little time to review.

Thanks! =]

iurisilvio commented 10 years ago

I don't know if it is possible to merge it without conflicts, but the PR is fine.

The template_global is better than the context_processor in this case.

mikeboers commented 10 years ago

I've made the minimal change in 68a91a151634a87533620fefeff9e3ce7a7eed0b

Thanks for pointing this out (so long ago)!