search

mikebrady / shairport-sync-docker

Docker setup for Shairport Sync
MIT License
49 stars 19 forks source link

add pulseaudio support #4

Open orrpan opened 3 years ago

mikebrady commented 3 years ago

Thanks for this suggestion -- I've been thinking about it for a long time. The problem I have with it is that I would rather not include PulseAudio in the runtime -- it is an inferior solution to the ALSA subsystem for this purpose and is quite bulky. So, by including pulse audio support in the build of Shairport Sync, as you have done, it seems to me that if someone really wanted to use PulseAudio at runtime, they could install the library themselves.

hanerd commented 3 years ago

Installing at runtime kinda breaks the concept behind containerization, though.

I get your concerns, but would it make sense to have both shairport-sync:<tag> and shairport-sync:pulseaudio-<tag> containers?

While pulse is definitely inferior to alsa, there are use cases where it's necessary. I run multiple docker containers that need access to the sound card and just can't get that to work with ALSA, but it's pretty seamless with pulse.

charlesomer commented 3 years ago

Just wanted to add that I think having PulseAudio support would make using a Bluetooth device much easier when using docker. Having two tags sounds like a good idea to give people the option :)

tmigone commented 2 years ago

+1 to this request, having something like shairport-sync:pulseaudio-<tag> would be sweet.