search

mikebrady / shairport-sync-for-openwrt

This is an OpenWrt package for building and installing Shairport Sync
45 stars 22 forks source link

Startup script improvements #14

Closed jekkos closed 7 years ago

jekkos commented 8 years ago

Add netwait script to wait for network interfaces before starting shairport (OpenWrt ticket #19427) Automatically add multicast route to wlan interface if embedded mdns is configured

mikebrady commented 8 years ago

Hi there. Just saw this now, so apologies for the delay.

A couple of things

  1. The addition of the route is hardwired the wlan0. It seems to me that it is not always the right choice.
  2. I see that the netwait script is a standalone fix for a problem which seems to be hardware specific and that is actually unrelated to Shairport Sync, although it may affect it. Would it not be better to advise the user that it might be necessary and point to it in the instructions? My logic is that I don't have this problem with Barrier Breaker on a TP-Link 710, so I wouldn't need it.
mikebrady commented 7 years ago

I'm going to decline this pull request. If you want to resubmit it, please have a look at the issues referred to above.