search

mikebrady / shairport-sync

AirPlay and AirPlay 2 audio player
Other
7.2k stars 571 forks source link

Possible SYN flooding on port 5000. #1107

Closed PieGuy314 closed 2 years ago

PieGuy314 commented 3 years ago

Upgraded today.

[2003797.120215] TCP: request_sock_TCP: Possible SYN flooding on port 5000. Sending cookies. Check SNMP counters.

3.3.7-OpenSSL-Avahi-ALSA-sysconfdir:/usr/local/etc

Linux hifipi 5.4.72-v8+ #1356 SMP PREEMPT Thu Oct 22 13:58:52 BST 2020 aarch64 GNU/Linux

mikebrady commented 3 years ago

Thanks for the post. I haven't seen this, and the latest version, 3.3.7, is 3.3.7rc3 which has been stable for some weeks.

Is it possible that your device is being attacked, or that there is some malfunction between your AirPlay source(s) and the Shairport Sync device? See here for example.

PieGuy314 commented 3 years ago

I'm not overly worried. Hadn't seen it myself before and wondered if it might be related to any code updates.

I'm fairly certain my network is safe. Probably something I was doing (ie. flicking between remotes).

mikebrady commented 3 years ago

Thanks -- please keep us apprised.

Hello71 commented 3 years ago

https://github.com/mikebrady/shairport-sync/blob/54cb9de1836fcb764bbae7397b6f79899f674268/rtsp.c#L2892

this is a fairly low buffer considering there is non-negligible work to be done between accepts (mainly creating a new thread). nginx for example uses 511.

mikebrady commented 3 years ago

Many thanks -- I'll push it up in a forthcoming revision.

github-actions[bot] commented 3 years ago

This issue has been inactive for 60 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

Hello71 commented 3 years ago

it's still 5

mikebrady commented 3 years ago

Darn it, I forgot. I’ll fix it — promise!

mikebrady commented 3 years ago

Finally, I set this to 255 in a development version -- it'll be posted soon. Apologies for the [amazingly long!] delay.

github-actions[bot] commented 2 years ago

This issue has been inactive for 60 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

PieGuy314 commented 2 years ago

Cough.

mikebrady commented 2 years ago

Done, I think.

kiwi-ed commented 2 years ago

I've seen exactly the same issue but in my case is wasn't Shairport-sync. I added network bonding and the type of bonding (round-robin) caused my issue after an intense investigation. It may seem related to shairport-sync but more likely it's related to your recent upgrade.

Hope is some way this helps..

github-actions[bot] commented 2 years ago

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.