search

mikebrady / shairport-sync

AirPlay and AirPlay 2 audio player
Other
7.23k stars 573 forks source link

Ignore volume control still sending min_db value in pvol, pipe output #1417

Closed greend139 closed 2 years ago

greend139 commented 2 years ago

I am using shairport-sync with the pipe output to forward to owntone. I have noticed that with SPS configured to ignore volume control, the pvol message on the metadata pipe is ignore by owntone with the following message. daapd | [2021-12-12 11:01:29] [DEBUG] player: Not applying Shairport airplay volume while software volume control is enabled (-27.38,0.00,-96.30,0.00)

I seems that in player.c SPS is always including the min_db value, and owntone refuses to apply the volume from the pvol value unless the last 3 values in the message are equal to ",0.00,0.00,0.00".

Not sure if this is regression in SPS, or a bug in owntone. I believe this used to work correctly.

Running development branch 4.1-dev-175-g8d3bbe22-AirPlay2-alac-OpenSSL-Avahi-ALSA-dummy-stdout-pipe-soxr-convolution-metadata-mqtt-dbus-mpris-sysconfdir:/etc

mikebrady commented 2 years ago

Thanks. I'll check this out.

mikebrady commented 2 years ago

Thanks again for reporting this regression, which was due to other changes in the volume control code. Would you be kind enough to try the latest version in the development branch to see if the problem has been resolved?

greend139 commented 2 years ago

Thanks for the quick fix. Tested in my docker container and it works as expected again.