search

mikebrady / shairport-sync

AirPlay and AirPlay 2 audio player
Other
7.29k stars 574 forks source link

Consider replacing alac with ffmpeg due to security issues #1478

Open ehaupt opened 2 years ago

ehaupt commented 2 years ago

alac has a long list of bugs and security issues. Please consider replacing it with ffmpeg.

This has been prompted by this FreeBSD issue.

mikebrady commented 2 years ago

Thanks for the suggestion and the information, Emanuel. As it happens Shairport Sync is just now capable of AirPlay 2 operation on FreeBSD and it is using an ffmpeg AAC decoder, so it should be possible to look at using the ffmpeg ALAC decoder. However, the size of the (libavcodec?) library may be an issue on smaller devices. Once the AirPlay 2 capability is released, I'll look into it.

ehaupt commented 2 years ago

Thank you @mikebrady! Maybe both, libavcodec and alac could be made optional (by configure argument). That would leave users and packagers a choice.

github-actions[bot] commented 2 years ago

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

ehaupt commented 2 years ago

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

Issue still valid.

github-actions[bot] commented 2 years ago

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

m1m1s1ku commented 2 years ago

Still valid.

ehaupt commented 2 years ago

This repo seems to have source code fixed to at least some extent:

https://github.com/nu774/qaac/tree/master/ALAC https://perkele.cc/software/ALAC

github-actions[bot] commented 1 year ago

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

ehaupt commented 1 year ago

Still valid.

mikebrady commented 1 year ago

Working (slowly) on stuff associated with this…

ehaupt commented 1 year ago

Still valid.

ehaupt commented 1 year ago

It is still relevant.

mikebrady commented 1 year ago

Yes it is!

mikebrady commented 10 months ago

This is still active!

mikebrady commented 10 months ago

Still active!

github-actions[bot] commented 8 months ago

This issue has been inactive for 28 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.