mikebrady / shairport-sync

AirPlay and AirPlay 2 audio player
Other
7.29k stars 574 forks source link

Virtual ALSA device not letting hw go to standby mode #1494

Closed everydayanchovies closed 2 years ago

everydayanchovies commented 2 years ago

Hi Mike,

Thanks a lot for your work.

I tried troubleshooting this error as far as I could but I'm stumped.

The situation:

This happens with all values of the disable standby mode setting. The device wakes up immediately after starting shairport.

I attach four files:

Let me know if I can give more info or debug something specific.

Cheers,

Max

Here is my alsa config:

pcm.mix {
        type plug
        slave.pcm "dmixer"
}

pcm.dmixer  {
        type dmix
        ipc_key 1024
    ipc_key_add_uid false
    ipc_perm 0666
        slave {
                pcm "hw:Boss2,0"
                period_time 0
                period_size 1024
                buffer_size 4096
                rate 44100
        }
        bindings {
                0 0
                1 1
        }
}

ctl.dmixer {
        type hw
        card 0
}

pcm.nswitch {
    type            softvol
    slave.pcm       "mix"
    control.name    "NintendoSwitch"
    control.card    0
}

pcm.cmus {
    type            softvol
    slave.pcm       "mix"
    control.name    "cmus"
    control.card    0
}

Here is my shairport config:

// Sample Configuration File for Shairport Sync
// Commented out settings are generally the defaults, except where noted.
// Some sections are operative only if Shairport Sync has been built with the right configuration flags.
// See the individual sections for details.

// General Settings
general =
{
    name = "Spinaash"; // This means "Hostname" -- see below. This is the name the service will advertise to iTunes.
//      The default is "Hostname" -- i.e. the machine's hostname with the first letter capitalised (ASCII only.)
//      You can use the following substitutions:
//              %h for the hostname,
//              %H for the Hostname (i.e. with first letter capitalised (ASCII only)),
//              %v for the version number, e.g. 3.0 and
//              %V for the full version string, e.g. 3.3-OpenSSL-Avahi-ALSA-soxr-metadata-sysconfdir:/etc
//      Overall length can not exceed 50 characters. Example: "Shairport Sync %v on %H".
//  password = "secret"; // leave this commented out if you don't want to require a password
    interpolation = "soxr"; // aka "stuffing". Default is "auto". Alternatives are "basic" or "soxr". Choose "soxr" only if you have a reasonably fast processor and Shairport Sync has been built with "soxr" support.
    output_backend = "alsa"; // Run "shairport-sync -h" to get a list of all output_backends, e.g. "alsa", "pipe", "stdout". The default is the first one.
//  mdns_backend = "avahi"; // Run "shairport-sync -h" to get a list of all mdns_backends. The default is the first one.
//  interface = "name"; // Use this advanced setting to specify the interface on which Shairport Sync should provide its service. Leave it commented out to get the default, which is to select the interface(s) automatically.
    port = 5000; // Listen for service requests on this port
    udp_port_base = 6001; // start allocating UDP ports from this port number when needed
    udp_port_range = 15; // look for free ports in this number of places, starting at the UDP port base. Allow at least 10, though only three are needed in a steady state.
//  regtype = "_raop._tcp"; // Use this advanced setting to set the service type and transport to be advertised by Zeroconf/Bonjour. Default is "_raop._tcp".

    drift_tolerance_in_seconds = 0.010; // allow a timing error of this number of seconds of drift away from exact synchronisation before attempting to correct it
    resync_threshold_in_seconds = 0.050; // a synchronisation error greater than this number of seconds will cause resynchronisation; 0 disables it

//  playback_mode = "stereo"; // This can be "stereo", "mono", "reverse stereo", "both left" or "both right". Default is "stereo".
    alac_decoder = "apple"; // This can be "hammerton" or "apple". This advanced setting allows you to choose
//      the original Shairport decoder by David Hammerton or the Apple Lossless Audio Codec (ALAC) decoder written by Apple.
//      If you build Shairport Sync with the flag --with-apple-alac, the Apple ALAC decoder will be chosen by default.

//  ignore_volume_control = "no"; // set this to "yes" if you want the volume to be at 100% no matter what the source's volume control is set to.
//  volume_range_db = 60 ; // use this advanced setting to set the range, in dB, you want between the maximum volume and the minimum volume. Range is 30 to 150 dB. Leave it commented out to use mixer's native range.
//  volume_max_db = 0.0 ; // use this advanced setting, which must have a decimal point in it, to set the maximum volume, in dB, you wish to use.
//      The setting is for the hardware mixer, if chosen, or the software mixer otherwise. The value must be in the mixer's range (0.0 to -96.2 for the software mixer).
//      Leave it commented out to use mixer's maximum volume.
    volume_control_profile = "standard" ; // use this advanced setting to specify how the airplay volume is transferred to the mixer volume.
//      "standard" makes the volume change more quickly at lower volumes and slower at higher volumes.
//      "flat" makes the volume change at the same rate at all volumes.
//  volume_range_combined_hardware_priority = "no"; // when extending the volume range by combining the built-in software attenuator with the hardware mixer attenuator, set this to "yes" to reduce volume by using the hardware mixer first, then the built-in software attenuator.
//  run_this_when_volume_is_set = "/full/path/to/application/and/args"; //  Run the specified application whenever the volume control is set or changed.
//      The desired AirPlay volume is appended to the end of the command line – leave a space if you want it treated as an extra argument.
//      AirPlay volume goes from 0 to -30 and -144 means "mute".

//  audio_backend_latency_offset_in_seconds = 0.0; // This is added to the latency requested by the player to delay or advance the output by a fixed amount.
//      Use it, for example, to compensate for a fixed delay in the audio back end.
//      E.g. if the output device, e.g. a soundbar, takes 100 ms to process audio, set this to -0.1 to deliver the audio
//      to the output device 100 ms early, allowing it time to process the audio and output it perfectly in sync.
    audio_backend_buffer_desired_length_in_seconds = 0.5; // If set too small, buffer underflow occurs on low-powered machines.
//      Too long and the response time to volume changes becomes annoying.
//      Default is 0.2 seconds in the alsa backend, 0.35 seconds in the pa backend and 1.0 seconds otherwise.
//  audio_backend_buffer_interpolation_threshold_in_seconds = 0.075; // Advanced feature. If the buffer size drops below this, stop using time-consuming interpolation like soxr to avoid dropouts due to underrun.
//  audio_backend_silent_lead_in_time = "auto"; // This optional advanced setting, either "auto" or a positive number, sets the length of the period of silence that precedes the start of the audio.
//      The default is "auto" -- the silent lead-in starts as soon as the player starts sending packets.
//      Values greater than the latency are ignored. Values that are too low will affect initial synchronisation.

//  dbus_service_bus = "system"; // The Shairport Sync dbus interface, if selected at compilation, will appear
//      as "org.gnome.ShairportSync" on the whichever bus you specify here: "system" (default) or "session".
//  mpris_service_bus = "system"; // The Shairport Sync mpris interface, if selected at compilation, will appear
//      as "org.gnome.ShairportSync" on the whichever bus you specify here: "system" (default) or "session".

//  resend_control_first_check_time = 0.10; // Use this optional advanced setting to set the wait time in seconds before deciding a packet is missing.
//  resend_control_check_interval_time = 0.25; //  Use this optional advanced setting to set the time in seconds between requests for a missing packet.
//  resend_control_last_check_time = 0.10; // Use this optional advanced setting to set the latest time, in seconds, by which the last check should be done before the estimated time of a missing packet's transfer to the output buffer.
//  missing_port_dacp_scan_interval_seconds = 2.0; // Use this optional advanced setting to set the time interval between scans for a DACP port number if no port number has been provided by the player for remote control commands
};

// Advanced parameters for controlling how Shairport Sync stays active and how it runs a session
sessioncontrol =
{
//  "active" state starts when play begins and ends when the active_state_timeout has elapsed after play ends, unless another play session starts before the timeout has fully elapsed.
//  run_this_before_entering_active_state = "/full/path/to/application and args"; // make sure the application has executable permission. If it's a script, include the shebang (#!/bin/...) on the first line
//  run_this_after_exiting_active_state = "/full/path/to/application and args"; // make sure the application has executable permission. If it's a script, include the shebang (#!/bin/...) on the first line
//  active_state_timeout = 10.0; // wait for this number of seconds after play ends before leaving the active state, unless another play session begins.

//  run_this_before_play_begins = "/full/path/to/application and args"; // make sure the application has executable permission. If it's a script, include the shebang (#!/bin/...) on the first line
//  run_this_after_play_ends = "/full/path/to/application and args"; // make sure the application has executable permission. If it's a script, include the shebang (#!/bin/...) on the first line

//  run_this_if_an_unfixable_error_is_detected = "/full/path/to/application and args"; // if a problem occurs that can't be cleared by Shairport Sync itself, hook a program on here to deal with it. An error code-string is passed as the last argument.
//    Many of these "unfixable" problems are caused by malfunctioning output devices, and sometimes it is necessary to restart the whole device to clear the problem.
//    You could hook on a program to do this automatically, but beware -- the device may then power off and restart without warning!
//  wait_for_completion = "no"; // set to "yes" to get Shairport Sync to wait until the "run_this..." applications have terminated before continuing

//  allow_session_interruption = "no"; // set to "yes" to allow another device to interrupt Shairport Sync while it's playing from an existing audio source
//  session_timeout = 120; // wait for this number of seconds after a source disappears before terminating the session and becoming available again.
};

// Back End Settings

// These are parameters for the "alsa" audio back end.
// For this section to be operative, Shairport Sync must be built with the following configuration flag:
// --with-alsa
alsa =
{
    output_device = "mix"; // the name of the alsa output device. Use "shairport-sync -h" to discover the names of ALSA hardware devices. Use "alsamixer" or "aplay" to find out the names of devices, mixers, etc
//  mixer_control_name = "AirPort"; // the name of the mixer to use to adjust output volume. No default. If not specified, no mixer is used and volume in adjusted in software.
//  mixer_control_index = 0; // the index of the mixer to use to adjust output volume. Default is 0. The mixer is fully identified by the combination of the mixer_control_name and the mixer_control_index, e.g. "PCM",0 would be such a specification.
//  mixer_device = "hw:Headphones"; // the mixer_device default is whatever the output_device is. Normally you wouldn't have to use this.

    output_rate = 44100; // can be "auto", 44100, 88200, 176400 or 352800, but the device must have the capability.
    output_format = "S16"; // can be "auto", "U8", "S8", "S16", "S16_LE", "S16_BE", "S24", "S24_LE", "S24_BE", "S24_3LE", "S24_3BE", "S32", "S32_LE" or "S32_BE" but the device must have the capability. Except where stated using (*LE or *BE), endianness matches that of the processor.

//  disable_synchronization = "no"; // Set to "yes" to disable synchronization. Default is "no" This is really meant for troubleshootingG.

//  period_size = <number>; // Use this optional advanced setting to set the alsa period size near to this value
//  buffer_size = <number>; // Use this optional advanced setting to set the alsa buffer size near to this value
//  use_mmap_if_available = "yes"; // Use this optional advanced setting to control whether MMAP-based output is used to communicate  with the DAC. Default is "yes"
//  use_hardware_mute_if_available = "no"; // Use this optional advanced setting to control whether the hardware in the DAC is used for muting. Default is "no", for compatibility with other audio players.
//  maximum_stall_time = 0.200; // Use this optional advanced setting to control how long to wait for data to be consumed by the output device before considering it an error. It should never approach 200 ms.
    use_precision_timing = "yes"; // Use this optional advanced setting to control how Shairport Sync gathers timing information. When set to "auto", if the output device is a real hardware device, precision timing will be used. Choose "no" for more compatible standard timing, choose "yes" to force the use of precision timing, which may cause problems.

    disable_standby_mode = "no"; // This setting prevents the DAC from entering the standby mode. Some DACs make small "popping" noises when they go in and out of standby mode. Settings can be: "always", "auto" or "never". Default is "never", but only for backwards compatibility. The "auto" setting prevents entry to standby mode while Shairport Sync is in the "active" mode. You can use "yes" instead of "always" and "no" instead of "never".
//  disable_standby_mode_silence_threshold = 0.040; // Use this optional advanced setting to control how little audio should remain in the output buffer before the disable_standby code should start sending silence to the output device.
//  disable_standby_mode_silence_scan_interval = 0.004; // Use this optional advanced setting to control how often the amount of audio remaining in the output buffer should be checked.
};

// Parameters for the "sndio" audio back end. All are optional.
// For this section to be operative, Shairport Sync must be built with the following configuration flag:
// --with-sndio
sndio =
{
//  device = "snd/0"; // optional setting to set the name of the output device. Default is the sndio system default.
//  rate = 44100; // optional setting  which can be 44100, 88200, 176400 or 352800, but the device must have the capability. Default is 44100.
    format = "S32"; // optional setting  which can be "U8", "S8", "S16", "S24", "S24_3LE", "S24_3BE" or "S32", but the device must have the capability. Except where stated using (*LE or *BE), endianness matches that of the processor.
//  round = <number>; // advanced optional setting to set the period size near to this value
//  bufsz = <number>; // advanced optional setting to set the buffer size near to this value
};

// Parameters for the "pa" PulseAudio  backend.
// For this section to be operative, Shairport Sync must be built with the following configuration flag:
// --with-pa
pa =
{
//  server = "host"; // Set this to override the default pulseaudio server that should be used.
//  sink = "Sink Name"; // Set this to override the default pulseaudio sink that should be used. (Untested)
//  application_name = "Shairport Sync"; //Set this to the name that should appear in the Sounds "Applications" tab when Shairport Sync is active.
};

// Parameters for the "jack" JACK Audio Connection Kit backend.
// For this section to be operative, Shairport Sync must be built with the following configuration flag:
// --with-jack
jack =
{
//  client_name = "shairport-sync"; // Set this to the name of the client that should appear in "Connections" when Shairport Sync is active.
//  autoconnect_pattern = ""; // Set this to a POSIX regular expression pattern that describes the ports you would like to connect to
//                                   automatically. Examples:
//                                   "system:playback_[12]"
//                                   "some_app_[0-9]*:in-[LR]"
//                                   "jack_mixer:in_2[78]"
//                                   Beware: if you make a syntax error, libjack might crash. In that case, fix it and start over.
//                                   For a good overview, look here: https://www.ibm.com/support/knowledgecenter/SS8NLW_11.0.1/com.ibm.swg.im.infosphere.dataexpl.engine.doc/c_posix-regex-examples.html
//  soxr_resample_quality = "none"; // Enable resampling by setting this to "very high", "high", "medium", "low" or "quick"
//  bufsz = <number>; // advanced optional setting to set the buffer size to this value
};

// Parameters for the "pipe" audio back end, a back end that directs raw CD-style audio output to a pipe. No interpolation is done.
// For this section to be operative, Shairport Sync must have been built with the following configuration flag:
// --with-pipe
pipe =
{
//  name = "/tmp/shairport-sync-audio"; // this is the default
};

// There are no configuration file parameters for the "stdout" audio back end. No interpolation is done.
// To include support for the "stdout" backend, Shairport Sync must be built with the following configuration flag:
// --with-stdout

// There are no configuration file parameters for the "ao" audio back end. No interpolation is done.
// To include support for the "ao" backend, Shairport Sync must be built with the following configuration flag:
// --with-ao

// For this section to be operative, Shairport Sync must be built with the following configuration flag:
// --with-convolution
dsp =
{

//////////////////////////////////////////
// This convolution filter can be used to apply almost any correction to the audio signal, like frequency and phase correction.
// For example you could measure (with a good microphone and a sweep-sine) the frequency response of your speakers + room,
// and apply a correction to get a flat response curve.
//////////////////////////////////////////
//
    convolution = "no";                   // Set this to "yes" to activate the convolution filter.
    convolution_ir_file = "/home/max/speaker_impulse.wav";  // Impulse Response file to be convolved to the audio stream
    convolution_gain = 10.0;              // Static gain applied to prevent clipping during the convolution process
//  convolution_max_length = 44100;       // Truncate the input file to this length in order to save CPU.

//////////////////////////////////////////
// This loudness filter is used to compensate for human ear non linearity.
// When the volume decreases, our ears loose more sentisitivity in the low range frequencies than in the mid range ones.
// This filter aims at compensating for this loss, applying a variable gain to low frequencies depending on the volume.
// More info can be found here: https://en.wikipedia.org/wiki/Equal-loudness_contour
// For this filter to work properly, you should disable (or set to a fix value) all other volume control and only let shairport-sync control your volume.
// The setting "loudness_reference_volume_db" should be set at the volume reported by shairport-sync when listening to music at a normal listening volume.
//////////////////////////////////////////
//
    loudness = "yes";                      // Set this to "yes" to activate the loudness filter
    loudness_reference_volume_db = -11.0; // Above this level the filter will have no effect anymore. Below this level it will gradually boost the low frequencies.

};

// How to deal with metadata, including artwork
// For this section to be operative, Shairport Sync must be built with at one (or more) of the following configuration flags:
// --with-metadata, --with-dbus-interface, --with-mpris-interface or --with-mqtt-client.
// In those cases, "enabled" and "include_cover_art" will both be "yes" by default
metadata =
{
//  enabled = "yes"; // set this to yes to get Shairport Sync to solicit metadata from the source and to pass it on via a pipe
//  include_cover_art = "yes"; // set to "yes" to get Shairport Sync to solicit cover art from the source and pass it via the pipe. You must also set "enabled" to "yes".
//  cover_art_cache_directory = "/tmp/shairport-sync/.cache/coverart"; // artwork will be  stored in this directory if the dbus or MPRIS interfaces are enabled or if the MQTT client is in use. Set it to "" to prevent caching, which may be useful on some systems
//  pipe_name = "/tmp/shairport-sync-metadata";
//  pipe_timeout = 5000; // wait for this number of milliseconds for a blocked pipe to unblock before giving up
//  socket_address = "226.0.0.1"; // if set to a host name or IP address, UDP packets containing metadata will be sent to this address. May be a multicast address. "socket-port" must be non-zero and "enabled" must be set to yes"
//  socket_port = 5555; // if socket_address is set, the port to send UDP packets to
//  socket_msglength = 65000; // the maximum packet size for any UDP metadata. This will be clipped to be between 500 or 65000. The default is 500.
};

// How to enable the MQTT-metadata/remote-service
// For this section to be operative, Shairport Sync must be built with the following configuration flag:
// --with-mqtt-client
mqtt =
{
//  enabled = "no"; // set this to yes to enable the mqtt-metadata-service
//  hostname = "iot.eclipse.org"; // Hostname of the MQTT Broker
//  port = 1883; // Port on the MQTT Broker to connect to
//  username = NULL; //set this to a string to your username in order to enable username authentication
//  password = NULL; //set this to a string you your password in order to enable username & password authentication
//  capath = NULL; //set this to the folder with the CA-Certificates to be accepted for the server certificate. If not set, TLS is not used
//  cafile = NULL; //this may be used as an (exclusive) alternative to capath with a single file for all ca-certificates
//  certfile = NULL; //set this to a string to a user certificate to enable MQTT Client certificates. keyfile must also be set!
//  keyfile = NULL; //private key for MQTT Client authentication
//  topic = NULL; //MQTT topic where this instance of shairport-sync should publish. If not set, the general.name value is used.
//  publish_raw = "no"; //whether to publish all available metadata under the codes given in the 'metadata' docs.
//  publish_parsed = "no"; //whether to publish a small (but useful) subset of metadata under human-understandable topics
//  Currently published topics:artist,album,title,genre,format,songalbum,volume,client_ip,
//  Additionally, empty messages at the topics play_start,play_end,play_flush,play_resume are published
//  publish_cover = "no"; //whether to publish the cover over mqtt in binary form. This may lead to a bit of load on the broker
//  enable_remote = "no"; //whether to remote control via MQTT. RC is available under `topic`/remote.
//  Available commands are "command", "beginff", "beginrew", "mutetoggle", "nextitem", "previtem", "pause", "playpause", "play", "stop", "playresume", "shuffle_songs", "volumedown", "volumeup"
};

// Diagnostic settings. These are for diagnostic and debugging only. Normally you should leave them commented out
diagnostics =
{
//  disable_resend_requests = "no"; // set this to yes to stop Shairport Sync from requesting the retransmission of missing packets. Default is "no".
    log_output_to = "stdout"; // set this to "syslog" (default), "stderr" or "stdout" or a file or pipe path to specify were all logs, statistics and diagnostic messages are written to. If there's anything wrong with the file spec, output will be to "stderr".
//  statistics = "no"; // set to "yes" to print statistics in the log
    log_verbosity = 2; // "0" means no debug verbosity, "3" is most verbose.
//  log_show_file_and_line = "yes"; // set this to yes if you want the file and line number of the message source in the log file
//  log_show_time_since_startup = "no"; // set this to yes if you want the time since startup in the debug message -- seconds down to nanoseconds
//  log_show_time_since_last_message = "yes"; // set this to yes if you want the time since the last debug message in the debug message -- seconds down to nanoseconds
//  drop_this_fraction_of_audio_packets = 0.0; // use this to simulate a noisy network where this fraction of UDP packets are lost in transmission. E.g. a value of 0.001 would mean an average of 0.1% of packets are lost, which is actually quite a high figure.
//  retain_cover_art = "no"; // artwork is deleted when its corresponding track has been played. Set this to "yes" to retain all artwork permanently. Warning -- your directory might fill up.
};
mikebrady commented 2 years ago

Thanks for the post. I edited it slightly for layout.

Could you clarify this please:

This happens with all values of the disable standby mode setting. The device wakes up immediately after starting shairport.

Do these two sentences refer to when you're using the dmix device only? In other words, is it the case that when you output from Shairport Sync to hw:2, the disable_standby_mode setting is correctly observed; and that when Shairport Sync outputs to the dmix device, the disable_standby_mode is totally ignored and the DAC never gets into standby mode?

everydayanchovies commented 2 years ago

Yes, I am now running through all my tests again to reproduce but as I have to wait for the device to go to standby it will take a while.

Using hw:2 and no standby preference (commented out):

$ sudo systemctl stop shairport-sync.service
$ cat /proc/asound/card2/pcm0p/sub0/status
-> closed
$ sudo systemctl start shairport-sync.service
-> state: RUNNING [...]

After a couple of minutes, the DAC has still not entered standby mode. (Contradicting what I've said so far, sorry, I must have misremembered.) Killing shairport immediatly puts it in standby mode. I haven't connected to it, and so nothing is playing. Reading in the codebase I expect it to start idle and only wake on playback, but maybe I am mistaken. Furthermore I didn't find a timeout to standby, but only a silence threshold.

So I now wonder why the DAC doesn't enter standby in this standard configuration (no dmix).

I then changed the config to use the Master mix channel on the DAC instead of softvol.

Then I played something, and stopped playback. I noticed shairport correctly entered am_inactive mode, but the DAC is still awake.

         0.000483482 "rtsp.c:2579" Connection 1: TEARDOWN a PTP stream.
         0.000327296 "player.c:1670" Cancelling AP2 timing, control and audio threads...
         0.000052259 "player.c:1673" Connection 1: Delete Realtime Audio Stream thread
         0.000169760 "rtp.c:1865" Realtime Audio Receiver Cleanup Start.
         0.000125685 "rtp.c:1868" Connection 49290: closing realtime audio port 2249835881
         0.000038815 "rtp.c:1870" Realtime Audio Receiver Cleanup Done.
         0.000160722 "player.c:1687" Connection 31: Delete AirPlay 2 Control thread
         0.000385111 "rtp.c:1634" Connection 1: AP2 Control Receiver Cleanup.
         0.000103018 "rtp.c:1636" Connection 1: UDP control port 51492 closed.
         0.000143130 "rtp.c:1325" Connection 1: Clear anchor information.
         0.000503019 "player.c:1742" Connection 1: player terminated.
         0.000182296 "player.c:3387" pend
         0.000099981 "rtsp.c:2584" Connection 1: TEARDOWN phase one complete
        10.000236624 "activity_monitor.c:87" aend
         0.000127482 "activity_monitor.c:172" am_state: am_inactive
$ cat /proc/asound/card2/pcm0p/sub0/status
-> state: RUNNING
owner_pid   : 522285
trigger_time: 332577.091849598
tstamp      : 332741.721392098
delay       : 2056
avail       : 129016
avail_max   : 129016
-----
hw_ptr      : 7260216
appl_ptr    : 7262272

Note, this is also interesting:

$ ps au | grep 522285
-> max       522908  0.0  0.0   5912   628 pts/1    S+   14:56   0:00 grep --color=auto 522285

I'm using a self-compiled build from the development branch: 4.1-dev-388-g16c5874d-AirPlay2-alac-OpenSSL-Avahi-ALSA-jack-soxr-convolution-metadata-sysconfdir:/etc

Thanks for the fast reply.

mikebrady commented 2 years ago

Thanks for the information. Here is what I think should be happening:

If there is no disable_standby_mode set, then by default it is off. That means that the Shairport Sync ("SPS") will stop sending audio to it as soon as the audio programme stops. In this mode, the am_state has no effect on the DAC's standby mode: if audio is coming from the source, it'll be sent to the DAC; if not, no audio will be sent.

If disable_standby_mode is set to "auto", then SPS will keep the DAC out of the standby mode only when the am_state is am_active. It does this by ensuring the the DAC is fed with audio, sending silent frames if necessary, while the am_state is am_active. If disable_standby_mode is "yes" or "always", then SPS will keep the DAC out of the standby mode all the time, sending silent frames whenever necessary.

Now, when SPS is driving the DAC directly ("hw:2"), it controls what goes to the DAC. However, when SPS is driving the dmix device, it is outputting to the dmix device and not to the DAC. It is up to the dmix device as to what it sends to the DAC hardware – SPS has no control over that, I'm afraid.

But there is another aspect to this. "Standby" is different to "closed" (i.e. standby ≠ closed). That is, a DAC could be open and could enter and leave standby mode while remaining open, sometimes resulting in audible clicks or pops.

Does that correspond with what you are seeing?

everydayanchovies commented 2 years ago

Yes, that clears things up a lot.

But there is another aspect to this. "Standby" is different to "closed" (i.e. standby ≠ closed). That is, a DAC could be open and could enter and leave standby mode while remaining open, sometimes resulting in audible clicks or pops.

I was concerned that the DAC was recieving silent frames while the device was open, but now I assume it does no harm to keep it open.

Thank you!

everydayanchovies commented 2 years ago

I found the issue (in my opinion it is an issue): if use_precision_timing is "yes" then the DAC never sleeps.

https://github.com/mikebrady/shairport-sync/blob/95353858a6e8e6426dea710e8d490151847f0f95/audio_alsa.c#L1275

That makes sense, but I didn't expect that to happen.

My DAC now sleeps :)

mikebrady commented 2 years ago

Very interesting, thanks. Just to be clear, are your referring to the real DAC — hw:2 — or the dmix device?

everydayanchovies commented 2 years ago

Both, actually! It enters sleep within a second of playback stopping with use_precision_timing="no".

mikebrady commented 2 years ago

Thanks. I must look into that some more.