search

mikebrady / shairport-sync

AirPlay and AirPlay 2 audio player
Other
7.3k stars 574 forks source link

No -M option to know what's playing on ? #35

Closed miguelonthenet closed 9 years ago

miguelonthenet commented 9 years ago

Hi,

Not sure if it's a regression, but on shairport, there was an option which store the Metadata in a file : To enable the output of metadata, the -M flag must be set to instruct shairport where to save the output. A fifo named now_playing will be created, and records will be written to it when tracks are changed.

Would you get it work ? It might be usefull :)

Thanks for your work Regards

Miguelonthenet

mikebrady commented 9 years ago

Hi @miguelonthenet. Thanks for your interest in shairport-sync. TBH the metadata is a not a feature I've thought of implementing. I was much more interested in getting synchronous audio to work properly. I can't promise when I'll get around to looking at it, though if it was properly implemented in the original shairport, it shouldn't be too hard to add back in.

miguelonthenet commented 9 years ago

Tks for your feedback ! I hope it will be taken into account one day, it will be usefull for my vintage radio to display the song played even on airplay.

Best Regards Miguel

mikebrady commented 9 years ago

BTW, which version of shairport has the metadata option working well? I might take a look at the code...

miguelonthenet commented 9 years ago

https://github.com/abrasive/shairport#metadata I did not check if it is working, I look for that only for 1 week :p

mikebrady commented 9 years ago

Thanks. Actually it looks fairly straightforward to re-incorporate the metadata stuff, so I'll give it a try in the next while, when work permits.

moritzmhmk commented 9 years ago

I did fork shairport last year just to fix coverart not being synchronous to the other metadata - hope it will help you make shairport-sync even more awesome :)

see: https://github.com/moritzmhmk/shairport/commit/c97006b8c4ed58fe8000a3eea0f94a60efe8fdc0 https://github.com/moritzmhmk/shairport/commit/9a2998e316539d7cea7533a6922dc3fddfb14ecb

fnordism commented 9 years ago

Maybe adding a function if Airplay doesn't fetch coverart, shairport-sync is executing a command; for example get-cover

https://github.com/DirectorX/get-cover

mikebrady commented 9 years ago

I'm trying to incorporate the metadata functionality from https://github.com/abrasive/shairport#metadata, but it is taking a little more time than I thought because I want to make is compatible with PolarSSL as well as OpenSSL...

mikebrady commented 9 years ago

I've done some work on this, a lot different from the original. Documentation is in the files rtsp.c and player.c. There is a sample metadata reader available in a new repository, see https://github.com/mikebrady/shairport-sync-metadata-reader.

mikebrady commented 9 years ago

I'm going to close this issue, if that's okay. There's a metadata feature in the 2.3 branch now. Feel free to reopen this if necessary.