mikebrady / shairport-sync

AirPlay and AirPlay 2 audio player
Other
7.3k stars 574 forks source link

Metadata is written to pipe before cmd_start_returns_output #791

Closed Unkn0wn-MDCLXIV closed 5 years ago

Unkn0wn-MDCLXIV commented 5 years ago

I want shairport-sync to launch a metadata reader when it starts playing. My metadata reader is working fine, but it needs a second to launch and read from the pipe.

The metadata is written to the pipe as soon as I click play on my device and not until my reader returns any output, so it cannot read the very first metadata.

mikebrady commented 5 years ago

Thanks for the post.

The command that is launched just before play begins can be set to wait for completion, but that probably still would not be enough to ensure that the metadata reader was ready to accept metadata by the time the first item is sent?

Is there a reason why the metadata reader can not be launched long before Shairport Sync?

Unkn0wn-MDCLXIV commented 5 years ago

Well, nvm.

It was actually a full featured metadata reader which publishes the metadata via mqtt. But I just noticed that this feature is included in your development version :disappointed:

mikebrady commented 5 years ago

Ouch! My commiserations. 😟

mikebrady commented 5 years ago

Would it be okay to close this please?