search

mikebridge / Liquid.NET

.Net Port of the Liquid template language
MIT License
61 stars 15 forks source link

Add new option for Erroring when variable is missing #59

Open schotime opened 8 years ago

schotime commented 8 years ago

Split the erroring so that if the variable doesn't exist, it gives a different error from when the value is undefined. I've added a new option so you can turn either on.

Let me know what you think.

codecov-io commented 8 years ago

Current coverage is 92.09%

Merging #59 into master will increase coverage by +0.02% as of 00ec8d5

@@            master     #59   diff @@
======================================
  Files          140     140       
  Stmts         4565    4581    +16
  Branches       473     476     +3
  Methods          0       0       
======================================
+ Hit           4203    4219    +16
  Partial        148     148       
  Missed         214     214

Review entire Coverage Diff as of 00ec8d5

Powered by Codecov. Updated on successful CI builds.

mikebridge commented 8 years ago

Thanks, I'll have a few minutes to look at it over the next day or so.

schotime commented 8 years ago

HI @mikebridge Where is this at? What is the status of the project? Cheers Adam

mikebridge commented 8 years ago

@schotime Sorry, this fell off my plate but I intend to get another release happening soon. I actually already have an implementation for this (https://github.com/mikebridge/Liquid.NET/issues/22) but I was hoping to clean up some of the parsing pipeline in the front end before making another release.

codecov-io commented 5 years ago

Codecov Report

Merging #59 into master will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #59      +/-   ##
=========================================
- Coverage    0.02%   0.02%   -0.01%     
=========================================
  Files         140     140              
  Lines        4922    4939      +17     
  Branches      453     456       +3     
=========================================
  Hits            1       1              
- Misses       4921    4938      +17
Impacted Files Coverage Δ
Liquid.NET/src/TemplateContext.cs 0% <0%> (ø) :arrow_up:
Liquid.NET/src/Constants/IndexDereferencer.cs 0% <0%> (ø) :arrow_up:
Liquid.NET/src/Utils/LiquidExpressionResult.cs 0% <0%> (ø) :arrow_up:
Liquid.NET/src/Expressions/VariableReference.cs 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba066fb...1568da7. Read the comment docs.